Skip to content

e-mail attachment flow#1079

Open
bikubi wants to merge 19 commits intomainfrom
bikubi/email-att-flow
Open

e-mail attachment flow#1079
bikubi wants to merge 19 commits intomainfrom
bikubi/email-att-flow

Conversation

@bikubi
Copy link
Contributor

@bikubi bikubi commented Jul 23, 2025

  • implement similar to / within post-upload
    • different intro
    • with pdf redaction
    • different flow: keep request update parts (status etc.), remove/skip message parts (date etc.)
  • update link in notification e-mails -- tested only up to a point, could not simulate this specific e-mail locally...
  • renamed "post-upload" to "edit-message-flow", because it is used for non-postal e-mails now, too.
    • other ideas welcome.. i only had "message-upsert" as an alt :)
    • arguably edit-message-flow.vue (née post-upload.vue) could be split into sub-components, but with the flow graph, one-big-component-which-does-two-things might be the lesser evil
    • nb. https://github.com/okfde/fragdenstaat_de/tree/bikubi/email-att-flow matches the renames

@bikubi bikubi requested a review from krmax44 July 23, 2025 15:10
@bikubi bikubi force-pushed the bikubi/email-att-flow branch 3 times, most recently from 34e90d5 to 1e35cb6 Compare July 28, 2025 09:59
@bikubi bikubi force-pushed the bikubi/email-att-flow branch 2 times, most recently from f03204a to 41129cc Compare August 4, 2025 16:19
bikubi added 10 commits August 6, 2025 13:49
@bikubi bikubi force-pushed the bikubi/email-att-flow branch from 41129cc to b33d736 Compare August 6, 2025 11:50
@bikubi
Copy link
Contributor Author

bikubi commented Aug 6, 2025

@krmax44 update summary:

  • the "alpha" message block now shows all badges from the request page, including fails_authenticity and is_escalation
    • I had to fix one test, not sure, will leave a comment in code
  • content_hidden, timestamps and layout are also closer now
  • STEP_INTRO_EMAIL is its own SFC
  • Problem? and Redact buttons work now
    • hack trick workaround to not rebuild them from scratch in Vue plus new API endpoints: I just used the regular forms
    • …with a special case to redirect to the email flow -- since we're only redirecting back to a landing page, this works out nicely
    • …but had to split them in two:
      • the trigger button is DjangoSlotted into the main Vue component
      • the modal part just renders into body- this seems to just work™
    • that content_hidden unhide button could work similarly
  • There is still the prominent Answer button that now has no counterpart... 🤔

⇒ if the form workaround is OK, feel free to review

bikubi
bikubi commented Aug 6, 2025
View reviewed changes
froide/foirequest/models/message.py

def fails_authenticity(self):
if not self.is_response or not self.is_email:
if not self.is_response or not self.is_email or not self.email_headers:
Copy link
Contributor Author

@bikubi bikubi Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krmax44 this fixed this failed run

@krmax44 krmax44 self-assigned this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krmax44 krmax44 Awaiting requested review from krmax44

Assignees

@krmax44 krmax44

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bikubi @krmax44